This repository has been archived by the owner on Oct 19, 2023. It is now read-only.
Allow versions like 3.5.0.1 for extension debian packages #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chingor13
reviewed
Dec 11, 2017
deb-package-builder/functions.sh
Outdated
| @@ -47,7 +47,7 @@ download_from_pecl() | |||
| with_retry "pecl download ${PECL_PACKAGE_NAME}" 6 | |||
| # determine the downloaded version | |||
| EXT_VERSION=$(ls ${PACKAGE_SHORT_NAME}-*.tgz | \ | |||
| sed "s/${PACKAGE_SHORT_NAME}-\([0-9][0-9]*\.[0-9][0-9]*\.[0-9][0-9]*\)\.tgz/\1/") | |||
| sed -E "s/${PACKAGE_SHORT_NAME}-([0-9]+.[0-9]+(.[0-9]+)+).tgz/\1/") | |||
There was a problem hiding this comment.
Do we need to keep the escaping for the "." characters?
chingor13
approved these changes
Dec 11, 2017
|
Just in case I'm running the package builder locally. I'll merge once it builds correct packages |
|
Now it's failing on opencensus-0.1.0RC1.tgz |
|
Doh, I uploaded a devel version of opencensus to ensure the build works. 0.1.0 will be tagged alpha and will be downloadable via In any case, we should probably make the version string even more lenient. Perhaps simply: |
|
Yeah I'm thinking to allow any postfix string |
|
It builds correct packages including
|
chingor13
approved these changes
Dec 11, 2017
frost-byte
pushed a commit
to Wiser-Owl/php-docker
that referenced
this pull request
May 9, 2021
…dPlatform#397) * Allow versions like 3.5.0.1 for extension debian packages * Escape dots in the regex * Allow any additional string in the version part
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.