Skip to content
This repository has been archived by the owner on Oct 19, 2023. It is now read-only.

Update extensions #399

Merged
merged 6 commits into from
Dec 13, 2017
Merged

Update extensions #399

merged 6 commits into from
Dec 13, 2017

Conversation

chingor13
Copy link
Member

@chingor13 chingor13 commented Dec 12, 2017

  • Add igbinary extension.~
  • Add ip2location extension. This also needs a shared library libip2location from source.
  • Add bitset extension.

Copy link
Contributor

@tmatsuo tmatsuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm little bit concerned with how we install ip2location lib.

if [ ${SHORT_VERSION} == "56" ]; then
download_from_pecl bitset 2.0.4
else
download_from_pecl bitset 3.0.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about to remove 3.0.1 here so that the builder will automatically follow the latest?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do.

@chingor13
Copy link
Member Author

We can hold off on the ip2location for now.

@chingor13 chingor13 merged commit 299da2d into master Dec 13, 2017
@chingor13 chingor13 deleted the update-extensions branch December 13, 2017 17:32
frost-byte pushed a commit to Wiser-Owl/php-docker that referenced this pull request May 9, 2021
* Add igbinary extension

* Add ip2location extension

* Build libip2location shared library as well

* Compile bitset extension

* use the latest bitset from PECL for PHP 7+

* skip ip2location until we can build it in a more secure way
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants