This repository has been archived by the owner on Oct 19, 2023. It is now read-only.
Handle google-cloud restructure for auto_prepend_file path #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmatsuo
reviewed
Mar 26, 2018
| echo Bootstrap::prependFileLocation() . PHP_EOL; | ||
| } else { | ||
| // default to same directory as the Bootstrap.php | ||
| echo dirname(Bootstrap::getFileName()) . DIRECTORY_SEPARATOR . 'bootstrap.php' . PHP_EOL; |
There was a problem hiding this comment.
Should we use realpath to make it an absolute path?
chingor13
changed the title
tmatsuo
reviewed
Mar 27, 2018
| echo Bootstrap::prependFileLocation() . PHP_EOL; | ||
| } else { | ||
| // default to same directory as the Bootstrap.php | ||
| echo realpath(dirname($reflection->getFileName()) . '/bootstrap.php') . PHP_EOL; |
There was a problem hiding this comment.
Whoops, yes. We really need to test this.
tmatsuo
approved these changes
Mar 27, 2018
tmatsuo
approved these changes
Mar 27, 2018
|
@tmatsuo Build is fixed. PTAL |
tmatsuo
approved these changes
Mar 27, 2018
frost-byte
pushed a commit
to Wiser-Owl/php-docker
that referenced
this pull request
May 9, 2021
…udPlatform#425) * Add script to locate the stackdriver prepend file * Remove unused constant * Use realpath * Fix prepend.php filename * Run integration test of build pipeline with enable_stackdriver_integration: true * Rename test directory for deployment host name length * Fix test directory in yaml config * shorten deploy tag for stackdriver deployment test * Set the google/cloud version for the build pipeline with stackdriver test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #427