fix: catch InvalidArg when checking maybe_secret (#1332)

GoogleCloudPlatform · Nov 18, 2024 · 2924202 · 2924202
1 parent 8e779dd
commit 2924202
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/data_validation/secret_manager.py b/data_validation/secret_manager.py
@@ -53,6 +53,6 @@ def maybe_secret(self, project_id: str, secret_id: str, version_id="latest") ->
             # Return the decoded payload.
             payload = response.payload.data.decode("UTF-8")
             return payload
-        except exceptions.NotFound:
+        except (exceptions.NotFound, exceptions.InvalidArgument):
             # The secret does not exist and therefore we can assume it is just a token to be returned.
             return secret_id
diff --git a/tests/system/test_secret_manager.py b/tests/system/test_secret_manager.py
@@ -1,7 +1,8 @@
 import os
+
 import pytest
-from data_validation import secret_manager
 
+from data_validation import secret_manager
 
 project_id = os.getenv("PROJECT_ID")
 
@@ -20,7 +21,7 @@ def test_access_gcp_secret_exists():
     secret_id = "db_test_user"
     manager = secret_manager.SecretManagerBuilder().build(client_type)
     secret_value = manager.maybe_secret(project_id, secret_id)
-    assert secret_value == "db_test_user"
+    assert secret_value == secret_id
 
 
 def test_access_gcp_secret_not_exists():