Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: distinct vpc remove legacy resources BREAKING CHANGE #922

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

alaincormier-ssc
Copy link
Collaborator

BREAKING CHANGE
final PR to close #883
the legacy network host project is removed

  • uncomment .../dns-project/public-dns.yaml
  • remove all resources in client-folder/standard/applications-infrastructure/firewall-policy
  • remove all resources in client-folder/standard/applications-infrastructure/host-project
  • remove all resources in client-folder/standard/firewall-policy
  • remove the host-project-id, standard-nonp-cidr and standard-pbmm-cidr setters

@alaincormier-ssc alaincormier-ssc changed the title Gh883 final client landing zone feat: distinct vpc remove legacy resources BREAKING CHANGE Apr 10, 2024
Copy link
Contributor

@fmichaelobrien fmichaelobrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Collaborator

@lucstjean-ssc lucstjean-ssc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@alaincormier-ssc alaincormier-ssc merged commit 824f7c2 into main Apr 11, 2024
3 checks passed
@alaincormier-ssc alaincormier-ssc deleted the gh883-final-client-landing-zone branch April 11, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Shared VPC - distinct host projects BREAKING CHANGE
3 participants