Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firestore test, test_listen_document, freezes and crashes CI #2442

Closed
gguuss opened this issue Oct 5, 2019 · 6 comments
Closed

Firestore test, test_listen_document, freezes and crashes CI #2442

gguuss opened this issue Oct 5, 2019 · 6 comments
Assignees
@BenWhitehead
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@gguuss
Copy link
Contributor

gguuss commented Oct 5, 2019

Running the code on our automation is failing, maybe the test is forking a process that never terminates?

This issue is to track and resolve this stuck test.
@gguuss
Copy link
Contributor Author

gguuss commented Oct 5, 2019

It actually looks like the test_listen_* tests may be failing?

@BenWhitehead
Copy link
Contributor

This is caused by googleapis/google-cloud-python#9008 which has a merged fix in googleapis/google-cloud-python#9337. We're just waiting on a new release of google-cloud-core with the fix.

@BenWhitehead
Copy link
Contributor

Related PR blocked by this same issue: #2427

@JustinBeckwith JustinBeckwith added the triage me I really want to be triaged. label Oct 7, 2019
@BenWhitehead BenWhitehead added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. and removed triage me I really want to be triaged. labels Oct 9, 2019
@BenWhitehead
Copy link
Contributor

My PR #2427 is now passing CI. @gguuss I've triggered a new build for the link you provided. If it's green, I'll close this issue.

@BenWhitehead
Copy link
Contributor

When I tried to re-run the build it failed because the PR had already been merged.

@gguuss Is it okay to close this now that the listen tests are working again?

@BenWhitehead BenWhitehead added the type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. label Oct 9, 2019
@gguuss
Copy link
Contributor Author

gguuss commented Oct 9, 2019

Yes, go ahead and close, I have verified this is passing now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenWhitehead BenWhitehead

Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JustinBeckwith @BenWhitehead @gguuss