Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typo in fs_update_document_increment sample #2427

Merged
merged 1 commit into from
Oct 9, 2019
Merged

fix: typo in fs_update_document_increment sample #2427

merged 1 commit into from
Oct 9, 2019

Conversation

BenWhitehead
Copy link
Contributor

Fixes #2374

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 1, 2019
@BenWhitehead
Copy link
Contributor Author

Build test hangs are due to googleapis/google-cloud-python#9008 submitted fix is googleapis/google-cloud-python#9337.

@BenWhitehead
Copy link
Contributor Author

Waiting for next release of google-cloud-core to include the fix.

@BenWhitehead BenWhitehead mentioned this pull request Oct 6, 2019
Closed
@andrewferlitsch
Copy link
Contributor

@BenWhitehead Just verifying from your comment, that this PR request is not ready for review until next release of google-cloud-core?

@BenWhitehead
Copy link
Contributor Author

@andrewferlitsch Correct. I think a new release is scheduled to be out in the next day or two.

@BenWhitehead
Copy link
Contributor Author

@crwilcox the build is green after the latest release. Can you please merge this?

gguuss
gguuss approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gguuss
Copy link
Contributor

gguuss commented Oct 9, 2019

@BenWhitehead Does this fix the listen tests?

@andrewferlitsch andrewferlitsch merged commit 44d1d15 into master Oct 9, 2019
@gguuss
Copy link
Contributor

gguuss commented Oct 9, 2019

I just tested, this fixes the listen tests, we should re-enable them.

@BenWhitehead BenWhitehead deleted the BenWhitehead-patch-1 branch October 9, 2019 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gguuss gguuss gguuss approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mistake in firestore numeric increment example for python
4 participants
@BenWhitehead @andrewferlitsch @gguuss @googlebot