Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix python Cloud Spanner tests. #1548

Merged
merged 2 commits into from
Jun 29, 2018
Merged

Fix python Cloud Spanner tests. #1548

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77ce1b0
Fix python Cloud Spanner tests.
jsimonweb Jun 29, 2018
ce1e06a
Lint.
jsimonweb Jun 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions spanner/cloud-client/snippets_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,20 @@ def temporary_database(spanner_instance):
database_id = unique_database_id()
snippets.create_database(SPANNER_INSTANCE, database_id)
snippets.insert_data(SPANNER_INSTANCE, database_id)
snippets.write_struct_data(SPANNER_INSTANCE, database_id)
database = spanner_instance.database(database_id)
database.reload()
yield database
database.drop()


@pytest.fixture(scope='module')
def temporary_database_with_all_columns(spanner_instance):
database_id = unique_database_id()
snippets.create_database(SPANNER_INSTANCE, database_id)
snippets.insert_data(SPANNER_INSTANCE, database_id)
snippets.add_column(SPANNER_INSTANCE, database_id)
snippets.add_timestamp_column(SPANNER_INSTANCE, database_id)
database = spanner_instance.database(database_id)
database.reload()
yield database
Expand Down Expand Up @@ -213,10 +227,11 @@ def test_add_timestamp_column(temporary_database, capsys):


@pytest.mark.slow
def test_update_data_with_timestamp(temporary_database, capsys):
def test_update_data_with_timestamp(temporary_database_with_all_columns,
capsys):
snippets.update_data_with_timestamp(
SPANNER_INSTANCE,
temporary_database.database_id)
temporary_database_with_all_columns.database_id)

out, _ = capsys.readouterr()

Expand Down