Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deflake bigtable and spanner tests. #2224

Merged
merged 1 commit into from
Jun 14, 2019
Merged

Deflake bigtable and spanner tests. #2224

merged 1 commit into from
Jun 14, 2019

Conversation

theacodes
Copy link
Contributor

  • Spanner doesn't actually promise the order of the results, so make the assertion work regardless of ordering.
  • Bigtable might need some more time to scale, so retry the assertion up to 10 times.

* Spanner doesn't actually promise the order of the results, so make the assertion work regardless of ordering.
* Bigtable might need some more time to scale, so retry the assertion up to 10 times.
@theacodes theacodes requested a review from engelke June 14, 2019 20:41
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 14, 2019
Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theacodes theacodes merged commit 231be14 into master Jun 14, 2019
@theacodes theacodes deleted the deflake-tests branch June 14, 2019 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants