Skip to content

Conversation

@BenWhitehead
Copy link
Contributor

  • bump google-cloud-firestore to v1.4.0

* bump google-cloud-firestore to v1.4.0
@BenWhitehead BenWhitehead requested a review from crwilcox August 14, 2019 21:46
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 14, 2019
Copy link
Contributor

@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BenWhitehead BenWhitehead merged commit 0ce1495 into GoogleCloudPlatform:master Aug 15, 2019
@BenWhitehead BenWhitehead deleted the numeric-increment branch August 15, 2019 19:08
@gguuss
Copy link
Contributor

gguuss commented Aug 15, 2019

@BenWhitehead /FYI if you make your commits in branches instead of forks, the tests will be run by travis.

@BenWhitehead
Copy link
Contributor Author

Travis doesn't run the tests in the continuous-integration/travis-ci/pr status linked to the sha?

@gguuss
Copy link
Contributor

gguuss commented Aug 15, 2019

If you do your PR in a fork, it runs lint alone, for branches on master it runs the integration tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants