feat: adds media translation samples #3117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
nnegrey
reviewed
Mar 23, 2020
|
|
||
| config = mediatranslation.StreamingTranslateSpeechConfig( | ||
| audio_config=mediatranslation.TranslateSpeechConfig( | ||
| audio_encoding='linear16', |
There was a problem hiding this comment.
Why is this a string?
It should be an enum like this: https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/speech/cloud-client/transcribe_model_selection.py#L43
There was a problem hiding this comment.
Acknowledged. I will raise that issue with product engineering.
nnegrey
reviewed
Mar 23, 2020
nnegrey
reviewed
Mar 23, 2020
nnegrey
reviewed
Mar 23, 2020
nnegrey
reviewed
Mar 23, 2020
nnegrey
reviewed
Mar 23, 2020
nnegrey
reviewed
Mar 23, 2020
nnegrey
reviewed
Mar 23, 2020
nnegrey
reviewed
Mar 23, 2020
nnegrey
reviewed
Mar 23, 2020
Comment on lines
74
to
80
| if __name__ == '__main__': | ||
| parser = argparse.ArgumentParser( | ||
| description=__doc__, | ||
| formatter_class=argparse.RawDescriptionHelpFormatter) | ||
| parser.add_argument('stream', help='File to stream to the API') | ||
| args = parser.parse_args() | ||
| translate_from_file(args.stream) |
There was a problem hiding this comment.
Suggested change
| if __name__ == '__main__': | |
| parser = argparse.ArgumentParser( | |
| description=__doc__, | |
| formatter_class=argparse.RawDescriptionHelpFormatter) | |
| parser.add_argument('stream', help='File to stream to the API') | |
| args = parser.parse_args() | |
| translate_from_file(args.stream) | |
| # [END media_translation_translate_from_file] |
nnegrey
reviewed
Mar 23, 2020
nnegrey
reviewed
Mar 23, 2020
| os.path.join(RESOURCES, 'audio.raw')) | ||
| out, err = capsys.readouterr() | ||
|
|
||
| assert re.search(r'Partial translation', out, re.DOTALL | re.I) |
There was a problem hiding this comment.
This seems fine, you can also just do : assert 'Partial translation' in out
nnegrey
reviewed
Mar 23, 2020
nnegrey
reviewed
Mar 23, 2020
nnegrey
reviewed
Mar 23, 2020
nnegrey
reviewed
Mar 23, 2020
nnegrey
reviewed
Mar 26, 2020
nnegrey
reviewed
Mar 26, 2020
nnegrey
reviewed
Mar 26, 2020
nnegrey
reviewed
Mar 26, 2020
|
Blocked by: #3116 |
nnegrey
reviewed
Mar 30, 2020
|
|
||
| client = mediatranslation.SpeechTranslationServiceClient() | ||
|
|
||
| speech_config = mediatranslation.TranslateSpeechConfig( |
There was a problem hiding this comment.
Nit: so up to you, personally I like to have the variables names match the argument they'll be used in later, but the object name is TranslateSpeechConfig
Suggested change
| speech_config = mediatranslation.TranslateSpeechConfig( | |
| audio_config = mediatranslation.TranslateSpeechConfig( |
Same thing for config below --> streaming_config, but again object name isn't the same.
nnegrey
approved these changes
Mar 30, 2020
nnegrey
added
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the following code snippet region tags: