Skip to content

[healthcare] fix: use uuid for resource names #3267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2020
Merged

[healthcare] fix: use uuid for resource names #3267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3154fa5
[healthcare] fix: use uuid for resource names
Apr 2, 2020
7be3d75
Merge branch 'master' into fix-fhir
Apr 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions healthcare/api-client/fhir/fhir_resources_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@
service_account_json = os.environ["GOOGLE_APPLICATION_CREDENTIALS"]

bundle = os.path.join(os.path.dirname(__file__), "resources/execute_bundle.json")
dataset_id = "test_dataset_{}".format(str(uuid.uuid4()))
fhir_store_id = "test_fhir_store-{}".format(str(uuid.uuid4()))
dataset_id = "test_dataset_{}".format(uuid.uuid4())
fhir_store_id = "test_fhir_store-{}".format(uuid.uuid4())
resource_type = "Patient"


Expand Down
5 changes: 3 additions & 2 deletions healthcare/api-client/fhir/fhir_stores_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
import pytest
import sys
import time
import uuid

from google.cloud import exceptions, storage

Expand All @@ -28,8 +29,8 @@
project_id = os.environ["GOOGLE_CLOUD_PROJECT"]
service_account_json = os.environ["GOOGLE_APPLICATION_CREDENTIALS"]

dataset_id = "test_dataset_{}".format(int(time.time()))
fhir_store_id = "test_fhir_store-{}".format(int(time.time()))
dataset_id = "test_dataset_{}".format(uuid.uuid4())
fhir_store_id = "test_fhir_store-{}".format(uuid.uuid4())

gcs_uri = os.environ["CLOUD_STORAGE_BUCKET"]
RESOURCES = os.path.join(os.path.dirname(__file__), "resources")
Expand Down