Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use crypto_key_path instead of crypto_key_path_path #3319

Merged
merged 5 commits into from
Apr 22, 2020
Merged

fix: use crypto_key_path instead of crypto_key_path_path #3319

merged 5 commits into from
Apr 22, 2020

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Apr 9, 2020 •
edited
Loading

crypto_key_path_path was added to the library in error and will be removed in a future version of the library

@busunkim96
fix: use crytpo_key_path instead of crypto_key_path_path
340fbad 
`crypto_key_path_path` was added in error and will be removed in a future version of the library
@busunkim96 busunkim96 requested review from daniel-sanche and a team as code owners April 9, 2020 17:38
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 9, 2020
gguuss
gguuss approved these changes Apr 9, 2020
View reviewed changes
Copy link
Contributor

@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@busunkim96 busunkim96 added the automerge Merge the pull request once unit tests and other checks pass. label Apr 10, 2020
@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@busunkim96 busunkim96 added automerge Merge the pull request once unit tests and other checks pass. and removed automerge Merge the pull request once unit tests and other checks pass. labels Apr 10, 2020
@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@irvifa
Copy link
Contributor

irvifa commented Apr 12, 2020

Hi, wondering why kokoro build is only failing on python 3.6 here.

@busunkim96
Copy link
Contributor Author

@irvifa It looks like a resource collision from the 3.7 and 3.6 tests running concurrently.

google.api_core.exceptions.FailedPrecondition: 400 The request cannot be fulfilled. Resource projects/python-docs-samples-tests/locations/global/keyRings/kms-samples/cryptoKeys/symmetric/cryptoKeyVersions/1 has value DESTROY_SCHEDULED in field crypto_key_version.state.

@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 15, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 15, 2020
@busunkim96 busunkim96 removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 15, 2020
@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

1 similar comment
@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@tmatsuo
Copy link
Contributor

tmatsuo commented Apr 22, 2020

The test failures are for other directories.

@tmatsuo tmatsuo added the automerge Merge the pull request once unit tests and other checks pass. label Apr 22, 2020
@tmatsuo
Copy link
Contributor

tmatsuo commented Apr 22, 2020

@busunkim96 If you saw resource conflicts between builds, can you file an issue so that we'll be able to fix later?

@gcf-merge-on-green gcf-merge-on-green bot merged commit 953bf7a into master Apr 22, 2020
@gcf-merge-on-green gcf-merge-on-green bot deleted the fix-crypto-key-path branch April 22, 2020 16:16
leahecole pushed a commit that referenced this pull request Apr 24, 2020
@busunkim96 @leahecole
fix: use crypto_key_path instead of crypto_key_path_path (#3319)
cce432b 
`crypto_key_path_path` was added to the library in error and will be removed in a future version of the library
busunkim96 added a commit to googleapis/python-kms that referenced this pull request Jun 4, 2020
@busunkim96
fix: use crypto_key_path instead of crypto_key_path_path [(#3319)](…
8068e87 
…GoogleCloudPlatform/python-docs-samples#3319)

`crypto_key_path_path` was added to the library in error and will be removed in a future version of the library
@release-please release-please bot mentioned this pull request Jun 16, 2020
Closed
This was referenced Jul 28, 2020
Closed
Merged
rsamborski pushed a commit that referenced this pull request Nov 8, 2022
@busunkim96
fix: use crypto_key_path instead of crypto_key_path_path [(#3319)](…
b9d19be 
…#3319)

`crypto_key_path_path` was added to the library in error and will be removed in a future version of the library
@rsamborski rsamborski mentioned this pull request Nov 8, 2022
Merged
8 tasks
rsamborski pushed a commit that referenced this pull request Nov 8, 2022
@busunkim96 @rsamborski
fix: use crypto_key_path instead of crypto_key_path_path [(#3319)](…
72dfb95 
…#3319)

`crypto_key_path_path` was added to the library in error and will be removed in a future version of the library
rsamborski pushed a commit that referenced this pull request Nov 11, 2022
@busunkim96 @rsamborski
fix: use crypto_key_path instead of crypto_key_path_path [(#3319)](…
d402078 
…#3319)

`crypto_key_path_path` was added to the library in error and will be removed in a future version of the library
rsamborski pushed a commit that referenced this pull request Nov 14, 2022
@busunkim96 @rsamborski
fix: use crypto_key_path instead of crypto_key_path_path [(#3319)](…
48170cb 
…#3319)

`crypto_key_path_path` was added to the library in error and will be removed in a future version of the library
dandhlee pushed a commit that referenced this pull request Nov 14, 2022
@busunkim96 @dandhlee
fix: use crypto_key_path instead of crypto_key_path_path [(#3319)](…
fbf98d7 
…#3319)

`crypto_key_path_path` was added to the library in error and will be removed in a future version of the library
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Oct 21, 2023
@busunkim96
fix: use crypto_key_path instead of crypto_key_path_path [(#3319)](…
a74d0e4 
…GoogleCloudPlatform/python-docs-samples#3319)

`crypto_key_path_path` was added to the library in error and will be removed in a future version of the library
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-sanche daniel-sanche daniel-sanche approved these changes

@gguuss gguuss gguuss approved these changes

@tmatsuo tmatsuo tmatsuo approved these changes

Assignees

@gguuss gguuss

Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@busunkim96 @irvifa @tmatsuo @gguuss @daniel-sanche @googlebot @kokoro-team