Update compute metadata hanging get example to use "wait_for_change". #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge". We need to include "wait_for_change" in order to perform a hanging get. In addition, we should deal with possible errors (like too many hanging gets). Finally, this change allows for any of the maintenance event supported by the metadata server.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
googlebot
added
the
cla: no
| headers=METADATA_HEADERS) | ||
|
|
||
| # During maintenance the service can return a 503, so these should | ||
| # be retried. | ||
| if r.status_code == 503: | ||
| time.sleep(1) | ||
| continue | ||
| elif r.status_code != requests.codes.ok: |
There was a problem hiding this comment.
The only status the docs mention that we should explicitly check for is 503. Any other error is better surfaced through the standard exception infrastructure rather than just sleeping and trying again.
Why not remove this and just use r.raise_for_status()?
…ge". We need to include "wait_for_change" in order to perform a hanging get. In addition, we should deal with possible errors (like too many hanging gets). Finally, this change allows for any of the maintenance event supported by the metadata server.
|
|
||
| last_etag = r.headers['etag'] | ||
| # [END hanging_get] | ||
|
|
||
| if r.text == 'MIGRATE_ON_HOST_MAINTENANCE': | ||
| in_maintenance = True | ||
| if r.text != 'NONE': |
There was a problem hiding this comment.
Since you've added an else, please switch the logic here.
|
@Galabar001 please register your github username internally to tell CLAbot about it and reply "I signed it" to get it to check again. |
…ge". We need to include "wait_for_change" in order to perform a hanging get. In addition, we should deal with possible errors (like too many hanging gets). Finally, this change allows for any of the maintenance event supported by the metadata server.
donmccasland
pushed a commit
that referenced
this pull request
Nov 11, 2022
8 tasks
msampathkumar
pushed a commit
that referenced
this pull request
Nov 14, 2022
* chore(deps): update all dependencies * revert update for google-auth * add pin for google-cloud-storage for py < 3.7 Co-authored-by: Anthonios Partheniou <partheniou@google.com>
8 tasks
arbrown
pushed a commit
that referenced
this pull request
Nov 14, 2022
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
8 tasks
dandhlee
pushed a commit
that referenced
this pull request
Nov 15, 2022
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
arbrown
pushed a commit
that referenced
this pull request
Nov 17, 2022
* chore(deps): update all dependencies * remove pin for python 3.6 Co-authored-by: Anthonios Partheniou <partheniou@google.com>
8 tasks
dandhlee
pushed a commit
that referenced
this pull request
Nov 17, 2022
* chore(deps): update all dependencies * remove pin for python 3.6 Co-authored-by: Anthonios Partheniou <partheniou@google.com>
8 tasks
telpirion
pushed a commit
that referenced
this pull request
Dec 2, 2022
* chore(deps): update all dependencies * revert Co-authored-by: Anthonios Partheniou <partheniou@google.com>
dandhlee
pushed a commit
that referenced
this pull request
Dec 2, 2022
* chore(deps): update all dependencies * revert Co-authored-by: Anthonios Partheniou <partheniou@google.com>
dandhlee
pushed a commit
that referenced
this pull request
Jan 26, 2023
8 tasks
Sita04
pushed a commit
that referenced
this pull request
Feb 7, 2023
* chore: update copyright year to 2022 PiperOrigin-RevId: 431037888 Source-Link: googleapis/googleapis@b3397f5 Source-Link: https://github.com/googleapis/googleapis-gen/commit/510b54e1cdefd53173984df16645081308fe897e Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTEwYjU0ZTFjZGVmZDUzMTczOTg0ZGYxNjY0NTA4MTMwOGZlODk3ZSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
telpirion
pushed a commit
that referenced
this pull request
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to include "wait_for_change" in order to perform a hanging get. In
addition, we should deal with possible errors (like too many hanging gets).
Finally, this change allows for any of the maintenance event supported by
the metadata server.