Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct path for the warmup call #3414

Merged
merged 3 commits into from
Apr 23, 2020
Merged

Conversation

oittaa
Copy link
Contributor

@oittaa oittaa commented Apr 16, 2020

No description provided.

@oittaa oittaa requested a review from a team as a code owner April 16, 2020 02:03
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Apr 16, 2020
@oittaa
Copy link
Contributor Author

oittaa commented Apr 16, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Apr 16, 2020
@busunkim96 busunkim96 added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 16, 2020
@@ -28,5 +28,5 @@ def test_warmup():
main.app.testing = True
client = main.app.test_client()

r = client.get('/')
r = client.get('/_ah/warmup')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For other reviewers: this is the warmup route in main.py

@app.route('/_ah/warmup')
def warmup():
# Handle your warmup logic here, e.g. set up a database connection pool
return '', 200, {}

@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 16, 2020
Copy link
Contributor

@tmatsuo tmatsuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oittaa Thanks for the contribution!

@tmatsuo tmatsuo added the automerge Merge the pull request once unit tests and other checks pass. label Apr 23, 2020
@tmatsuo tmatsuo added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 23, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 23, 2020
@tmatsuo tmatsuo merged commit bf0846d into GoogleCloudPlatform:master Apr 23, 2020
leahecole pushed a commit that referenced this pull request Apr 24, 2020
Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants