Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service Directory python snippets #3456
Service Directory python snippets #3456
Changes from 6 commits
1490a11
390ee2d
29d9d19
aaa8360
9995dc5
80df034
83b878d
506c1db
2fc3917
33440b6
a954aa7
a429af0
300370a
420e8ec
89a40fb
657b38d
cd5febe
322e70b
fb971a6
6dedabb
ad957b8
b3a9282
c3a32fe
36b2da6
1210541
8a991f5
cd2ef68
a64af6d
63e36f3
29d6707
f37d48d
542910a
e393114
ca3d5b3
40334b2
c9d52f5
4b54713
807730c
3f42d08
6680dc8
083801a
7f0f27b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it required to specify a location to use this library?
We don't currently have a env var for this in CI, so we would have to add one if it is needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The user needs to specify the location since its part of the resource path, i.e. i specify a namespace, you need to specify the project and the location that it is in.
Where would we need to add the env var for this? For now, I've just been setting it manually in my environment (
export GCLOUD_LOCATION='us-east1'
)