Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pub/Sub: clean up redundant/wrong region tag #4027

Merged
merged 2 commits into from
Jun 11, 2020
Merged

Pub/Sub: clean up redundant/wrong region tag #4027

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b3e732
nit: remove redundant/wrong region tag
anguillanneuf Jun 9, 2020
1ec999a
Merge branch 'master' into anguillanneuf-patch-1
anguillanneuf Jun 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions pubsub/cloud-client/subscriber.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,6 @@ def callback(message):

def receive_messages_with_custom_attributes(project_id, subscription_id, timeout=None):
"""Receives messages from a pull subscription."""
# [START pubsub_subscriber_sync_pull_custom_attributes]
# [START pubsub_subscriber_async_pull_custom_attributes]
from concurrent.futures import TimeoutError
from google.cloud import pubsub_v1
Expand Down Expand Up @@ -383,7 +382,6 @@ def callback(message):
except TimeoutError:
streaming_pull_future.cancel()
# [END pubsub_subscriber_async_pull_custom_attributes]
# [END pubsub_subscriber_sync_pull_custom_attributes]


def receive_messages_with_flow_control(project_id, subscription_id, timeout=None):
Expand Down