Skip to content

Conversation

@ace-n
Copy link

@ace-n ace-n commented Jul 16, 2020

Do not merge until functions_helloworld_storage_generic has been removed from the docs.

Python fix for b/135560881

@ace-n ace-n requested a review from a team as a code owner July 16, 2020 07:24
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 16, 2020
@tmatsuo tmatsuo added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 16, 2020
Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix failing tests. They look pretty minor.

@ace-n ace-n requested a review from engelke July 31, 2020 02:00
@ace-n ace-n removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 31, 2020
Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ace-n ace-n merged commit 688d20b into master Aug 4, 2020
@ace-n ace-n deleted the gcs-generic branch August 4, 2020 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants