Skip to content

dataflow/flex-templates: update commands to GA #4658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
davidcavazos merged 6 commits into from
Sep 15, 2020
Merged

dataflow/flex-templates: update commands to GA #4658

davidcavazos merged 6 commits into from
Sep 15, 2020

Conversation

@davidcavazos
Copy link

@davidcavazos davidcavazos commented Sep 9, 2020 •
edited
Loading

Simplify the instructions using the new GA gcloud commands. Also fix metadata names.

Fixes: #4623

Checklist

@davidcavazos davidcavazos requested a review from a team as a code owner September 9, 2020 21:47
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 9, 2020
@product-auto-label product-auto-label bot added api: dataflow Issues related to the Dataflow API. samples Issues that are directly related to samples. labels Sep 10, 2020
@davidcavazos davidcavazos added the blunderbuss: assign Instruct blunderbuss to assign someone label Sep 10, 2020
@blunderbuss-gcf blunderbuss-gcf bot removed the blunderbuss: assign Instruct blunderbuss to assign someone label Sep 10, 2020
@davidcavazos
Copy link
Author

davidcavazos commented Sep 15, 2020

Hi @leahecole, you've been assigned by the blunderbuss yet again :)
Again, small changes. Can you take a look whenever you have a chance?

@davidcavazos davidcavazos merged commit 92f83c8 into GoogleCloudPlatform:master Sep 15, 2020
@davidcavazos davidcavazos deleted the dataflow-flex-templates-ga branch September 15, 2020 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

@dinagraves dinagraves dinagraves approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@leahecole leahecole

@dinagraves dinagraves

Labels

api: dataflow Issues related to the Dataflow API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

metadata.json from "Using Flex Templates" docs results in syntax error on build

4 participants

@davidcavazos @busunkim96 @dinagraves @leahecole