-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update samples to support latest Google Cloud Python #656
Merged
+128
−170
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
6351867
Update to latest google-cloud-python
d106640
Fix some minor nox issues
91847ca
Update datastore samples for new google-cloud-python
1374be3
Update bigquery samples to use latest google-cloud
20d9de9
Update dns samples to use latest google-cloud
11575bc
Update logging samples to use latest google-cloud
f691fbd
Update pubsub samples to use latest google-cloud
22e3d53
Update storage samples to use latest google-cloud
03b27e8
Fix lint
3568981
Fix lint
49405df
Vision quickstart no longer fails on Py3
ce4c736
Address review comment.
ffdf1ca
Fix bigquery installed app sample
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update bigquery samples to use latest google-cloud
Change-Id: I6cbcca11be84baa7c40eed14b342cc916b9116d9
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may prefer to just consume the iterator right here:
There is too much suspense between this and the
for row in rows
(when the request(s) actually get made)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough, done.