Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use django-environ for django DEBUG settings #6792

Merged
merged 9 commits into from
Oct 11, 2021

Conversation

luigibertaco
Copy link
Contributor

@luigibertaco luigibertaco commented Oct 5, 2021

Description

Django examples use django-environ but it is not being used for the DEBUG settings.

Checklist

@luigibertaco luigibertaco requested review from glasnt and a team as code owners October 5, 2021 09:08
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Oct 5, 2021
@google-cla
Copy link

google-cla bot commented Oct 5, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Oct 5, 2021
@luigibertaco
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Oct 5, 2021
@dandhlee dandhlee added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 7, 2021
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 7, 2021
@leahecole leahecole added the blunderbuss: assign Instruct blunderbuss to assign someone label Oct 8, 2021
@blunderbuss-gcf blunderbuss-gcf bot removed the blunderbuss: assign Instruct blunderbuss to assign someone label Oct 8, 2021
@busunkim96 busunkim96 added the automerge Merge the pull request once unit tests and other checks pass. label Oct 11, 2021
@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 11, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 11, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit c6d84f6 into GoogleCloudPlatform:master Oct 11, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants