fix: Query modification and Refresh Client Issue #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
taherkl
commented
Feb 4, 2025
taherkl
commented
- Updated the query to get constraint details. Issue fixed when the same constraint names are used across different databases.
- Additional error handling when SchemaToSpannerDDL fails.
- Added RefreshSpannerClient call for VerifyCheckConstraintExpression API call
* fix: bug fixes 1. added refresh client on prepare migration click 2. error handling at load of schema --------- Co-authored-by: Vivek Yadav <vivek.yadav@ollion.com>
taherkl
requested review from
asthamohta and
shreyakhajanchi
and removed request for
a team
taherkl
changed the title
* Align the query * Update infoschema.go
asthamohta
approved these changes
Feb 4, 2025
pratickchokhani
pushed a commit
to pratickchokhani/spanner-migration-tool
that referenced
this pull request
Feb 6, 2025
…#1003) * Fix: bug fixes related to refresh client and error handling (GoogleCloudPlatform#85) * fix: bug fixes 1. added refresh client on prepare migration click 2. error handling at load of schema --------- Co-authored-by: Vivek Yadav <vivek.yadav@ollion.com> * query change * fix incorrect query * Align the query (GoogleCloudPlatform#87) * Align the query * Update infoschema.go --------- Co-authored-by: Vivek Yadav <105432992+VivekY1098@users.noreply.github.com> Co-authored-by: Vivek Yadav <vivek.yadav@ollion.com> Co-authored-by: taherkl <taher.lakdawala@ollion.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.