Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kms credentials configuration property does not work as documented #1271

Closed
zhumin8 opened this issue Sep 28, 2022 · 0 comments · Fixed by #1272
Closed

kms credentials configuration property does not work as documented #1271

zhumin8 opened this issue Sep 28, 2022 · 0 comments · Fixed by #1272
Labels
kms priority: p2

Comments

@zhumin8
Copy link
Contributor

zhumin8 commented Sep 28, 2022

Configuration property spring.cloud.gcp.kms.credentials.location does not work. Reproduce by setting this property in the sample app and observe log output.
Cause: the CredentialsProvider bean with kmsProperties is never created because Bean of same type already created in core.
@zhumin8 zhumin8 added the kms label Sep 28, 2022
@zhumin8 zhumin8 mentioned this issue Sep 28, 2022
Merged
zhumin8 added a commit that referenced this issue Oct 5, 2022
@zhumin8
fix(kms): to honor kms credentials when present. (#1272)
259a5d1 
fixes #1271.
Fix so `KmsAutoConfiguration` takes kms specific project id & credentials when present, otherwise fall back to core project id & credentials. Documentation is accurate, no change.
Added tests for all 4 scenarios.
kateryna216 added a commit to kateryna216/spring-cloud-gcp that referenced this issue Oct 20, 2022
@kateryna216
fix(kms): to honor kms credentials when present. (GoogleCloudPlatform…
34e4397 
…#1272)

fixes GoogleCloudPlatform#1271.
Fix so `KmsAutoConfiguration` takes kms specific project id & credentials when present, otherwise fall back to core project id & credentials. Documentation is accurate, no change.
Added tests for all 4 scenarios.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kms priority: p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(kms): to honor kms credentials when present. GoogleCloudPlatform/spring-cloud-gcp
2 participants
@zhumin8 @mpeddada1