Upgrade to Spring Boot 2.7.x #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
…ode property\nReplacement available since 2.5 (https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.5-Release-Notes/)
… group changed), added tests
…supports the protocol
mpeddada1
reviewed
Oct 12, 2022
...va/com/google/cloud/spring/autoconfigure/sql/R2dbcCloudSqlEnvironmentPostProcessorTests.java
Outdated
Show resolved
Hide resolved
...va/com/google/cloud/spring/autoconfigure/sql/R2dbcCloudSqlEnvironmentPostProcessorTests.java
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
|
I see Spring Cloud GCP 3.4.0 has been released with support for Spring Boot 2.7, which is great news! I guess https://github.com/GoogleCloudPlatform/spring-cloud-gcp#compatibility-with-spring-project-versions should be updated to indicate support for Spring Boot 2.7 is now available in version 3.4.0? |
|
I'll send a pull request; waiting on the last prerequisite. |
kateryna216
added a commit
to kateryna216/spring-cloud-gcp
that referenced
this pull request
Oct 20, 2022
Add valid driver versions for old R2DBC drivers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Spring Boot 2.7, the old R2DBC drivers for MySQL and Postgres were removed from the BOM (Spring Boot 2.7 release notes).
Spring Cloud GCP typically follows Spring Cloud, which supports both Spring Boot 2.6 and 2.7 in the same major version of their release trains. Additionally, we are not planning on releasing a major version, so the main goal is to not break existing users. This means keeping the old versions of drivers in Spring Cloud GCP R2DBC starters and managing the two drivers' version in Spring Cloud GCP BOM (
spring-cloud-gcp-dependencies).Postgres:
io.r2dbctoorg.postgres. Package named stayed the same, so the drivers are technically mutually compatible. However, the new driver uses a constant introduced in R2DBC SPI 0.9 (LOCK_WAIT_TIMEOUT), and so is not compatible with applications still on Spring Boot 2.6.x.0.8.12.RELEASE) is safe for both Spring Boot 2.6 and 2.7.MySQL
I've tested 5 combinations:
0.8.12.RELEASEdriver that's included in the starter.Addresses a part of #1200.