Upgrade to Spring Boot 3.0.0 #1287

JoeWang1127 · 2022-10-11T21:30:15Z

BEGIN_COMMIT_OVERRIDE

feat!: This release officially introduces Spring Boot 3.x compatibility. Note that breaking changes occur in this release. For full list of changes, refer to this.

END_COMMIT_OVERRIDE

Migration guide

Migration Guide from Spring Cloud GCP 3.x to 4.x

Changes applied to all modules

Minimum system requirements needed for upgrade
- Java 17
Spring Framework libraries upgrade
Upgrade plugin versions
Remove Java 8 and Java 11 in CI
Remove GraalVM and native compile in CI
Enable auto-configuration
fix Disconnect from spring-cloud-dependencies-parent #1294

Changes in each module

Bigquery
- Remove deprecated methods
- Replace ListenableFuture and SettableListenableFuture with CompletableFuture, reference
- Code polish
- Improve code coverage
Cloud SQL
- Remove support for r2dbc-mysql
- Fix Switch r2dbc-postgresql from groupId io.r2dbc to org.postgresql #1200
Datastore
- Remove deprecated methods and constructors
- Replace ClassTypeInformation with TypeInformation, reference
- Extend inheritance of DatastoreRepository, reference
- Change datastore-basic-sample to a web application to remove spring-shell dependency
- Fix broken tests
- Code polish
Firestore
- Replace ClassTypeInformation with TypeInformation, reference
- Code polish
Kotlin sample
- Code polish
Logging
- Replace javax.servlet with jakarta.servlet, reference
- Remove deprecated methods
- Code polish
Native support
- Delete the module, reference
Pubsub
- Replace ListenableFuture and SettableListenableFuture with CompletableFuture, reference
- Remove deprecated methods and constructors
- Code polish
Pubsub-stream-binder
- Change to functional programming model, reference
- Change spring-cloud-stream-binder-test to spring-cloud-stream-test-support, reference
- Fix broken tests
Secret Manager
- Delete GcpSecretManagerBootstrapConfiguration
Security
- Replace javax.servlet with jakarta.servlet, reference
Spanner
- Replace PreferredConstructor with InstanceCreatorMetadata
- Replace ClassTypeInformation with TypeInformation, reference
- Remove deprecated methods and constructors
- Extend inheritance of SpannerRepository, reference
- Fix broken tests
- Code polish
Storage
- Remove deprecated methods
- Code polish
- Improve code coverage
Trace, reference
- Remove spring-cloud-sleuth dependency
- Instrument trace using Observation API
- Remove deprecated methods
- Fix broken tests
Vision
- Replace ListenableFuture and SettableListenableFuture with CompletableFuture, reference
- Fix broken tests
- Code polish

JoeWang1127 · 2022-12-05T17:00:59Z

Hi @elefeint, could you sign the CLA? The previous one seems expired.

suztomo · 2022-12-05T19:11:22Z

CLA

JoeWang1127 · 2022-12-05T21:18:48Z

I modify the commits to reset the author, hope you don't mind, Elena.

meltsufin

First pass...

This an impressive amount of work! It would probably have been easier for reviewing to split into separate PRs, but I think we can manage this time.

In addition to the comments inline, here are a few more observations:

There are still many references in comments, documentation, and text for ListenableFuture which should be replaced with CompletableFuture.
spring-cloud-gcp-starter-sql-mysql-r2dbc directory has not been deleted
sql.adoc is not updated to remove mysql-r2dbc
Generally, please make sure that sample code in the documentation is still correct
There are still numerous mentions of Sleuth in the project, mostly in documentation.

pom.xml

...c/main/java/com/google/cloud/spring/autoconfigure/bigquery/GcpBigQueryAutoConfiguration.java

meltsufin · 2022-12-09T20:09:20Z

...main/java/com/google/cloud/spring/autoconfigure/trace/StackdriverTraceAutoConfiguration.java

 @EnableConfigurationProperties({GcpTraceProperties.class})
 @ConditionalOnProperty(
-    value = {"spring.sleuth.enabled", "spring.cloud.gcp.trace.enabled"},


What's the replacement for these properties in Spring Boot?

sleuth is removed from Spring Cloud release train, so sleuth-related properties are no longer exist.

Sleuth was replaced by Micrometer Tracing https://github.com/micrometer-metrics/tracing/wiki/Spring-Cloud-Sleuth-3.1-Migration-Guide

@JoeWang1127 Mike is asking a replacement of this property exists or not.

spring.sleuth.enabled doesn't exist anymore.

To use trace, set spring.cloud.gcp.trace.enabled to true.

Good. Ensure the migration document has the explanation.

spring-cloud-gcp-core/src/main/java/com/google/cloud/spring/core/util/MapBuilder.java

...spanner/src/test/java/com/google/cloud/spring/data/spanner/test/domain/SingerRepository.java

spring-cloud-gcp-dependencies/pom.xml

...g-cloud-gcp-samples/spring-cloud-gcp-data-multi-sample/src/main/java/com/example/Trader.java

meltsufin · 2022-12-09T21:08:03Z

.../spring-cloud-gcp-pubsub-stream-dead-letter-sample/src/main/resources/application.properties

@@ -16,8 +16,6 @@ spring.cloud.stream.gcp.pubsub.bindings.logUserMessage-in-0.consumer.ackMode=MAN
 # The application also subscribes to the dead letter topic to show that it's just another normal topic.
 spring.cloud.stream.bindings.deadLetterMessages-in-0.destination=my-dead-letter-topic

-spring.cloud.stream.gcp.pubsub.default.consumer.auto-create-resources=true


This is still in the docs though. Please update documentation as well.

The docs are updated.

I'm not sure whether we still need the polling example and I'll do more research about it.

The legacy imperative programming model has been removed, so we don't need the polling example now.

...les/spring-cloud-gcp-pubsub-stream-polling-sample/src/main/java/com/example/SinkExample.java

...ud-gcp-samples/spring-cloud-gcp-secretmanager-sample/src/main/resources/bootstrap.properties

…eter dependency

sonarqubecloud · 2023-01-19T16:46:12Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

81.6% Coverage
0.0% Duplication

HabeebCycle · 2023-01-19T22:10:43Z

Congrats guys on this nice job.

ls-urs-keller · 2023-01-24T13:39:41Z

Thank you for the work. Impatiently waiting for this to be published in maven central.

Harmelodic · 2023-01-31T08:45:17Z

It's released! 🚀

https://repo1.maven.org/maven2/com/google/cloud/spring-cloud-gcp-dependencies/4.0.0/

HabeebCycle · 2023-01-31T12:19:25Z

This is awesome. Thank you guys for this awesome work.

codependent · 2023-01-31T16:26:02Z

Congrats on the great work!

Is there any upgrade guide available?

I've run into this error after bumping up to 4.0.0:

Caused by: org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'spanReporter' defined in class path resource [org/springframework/boot/actuate/autoconfigure/tracing/zipkin/ZipkinConfigurations$ReporterConfiguration.class]: Failed to instantiate [zipkin2.reporter.AsyncReporter]: Factory method 'spanReporter' threw exception with message: Encoder doesn't match Sender: JSON PROTO3
	at org.springframework.beans.factory.support.ConstructorResolver.instantiate(ConstructorResolver.java:657)
	at org.springframework.beans.factory.support.ConstructorResolver.instantiateUsingFactoryMethod(ConstructorResolver.java:645)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.instantiateUsingFactoryMethod(AbstractAutowireCapableBeanFactory.java:1324)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBeanInstance(AbstractAutowireCapableBeanFactory.java:1161)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:561)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:521)
	at org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:326)
	at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:234)
	at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:324)
	at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:200)
	at org.springframework.beans.factory.config.DependencyDescriptor.resolveCandidate(DependencyDescriptor.java:254)
	at org.springframework.beans.factory.support.DefaultListableBeanFactory.doResolveDependency(DefaultListableBeanFactory.java:1405)
	at org.springframework.beans.factory.support.DefaultListableBeanFactory.resolveDependency(DefaultListableBeanFactory.java:1325)
	at org.springframework.beans.factory.support.ConstructorResolver.resolveAutowiredArgument(ConstructorResolver.java:885)
	at org.springframework.beans.factory.support.ConstructorResolver.createArgumentArray(ConstructorResolver.java:789)
	... 191 common frames omitted
Caused by: org.springframework.beans.BeanInstantiationException: Failed to instantiate [zipkin2.reporter.AsyncReporter]: Factory method 'spanReporter' threw exception with message: Encoder doesn't match Sender: JSON PROTO3
	at org.springframework.beans.factory.support.SimpleInstantiationStrategy.instantiate(SimpleInstantiationStrategy.java:171)
	at org.springframework.beans.factory.support.ConstructorResolver.instantiate(ConstructorResolver.java:653)
	... 205 common frames omitted
Caused by: java.lang.IllegalArgumentException: Encoder doesn't match Sender: JSON PROTO3
	at zipkin2.reporter.AsyncReporter$Builder.build(AsyncReporter.java:201)
	at org.springframework.boot.actuate.autoconfigure.tracing.zipkin.ZipkinConfigurations$ReporterConfiguration.spanReporter(ZipkinConfigurations.java:123)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at org.springframework.beans.factory.support.SimpleInstantiationStrategy.instantiate(SimpleInstantiationStrategy.java:139)
	... 206 common frames omitted

JoeWang1127 · 2023-01-31T16:32:30Z

Hi @codependent, here is the migration guide.

Feel free to file an issue if you have any questions. Thanks.

These are residual files from sample modules that are removed as part of #1287. They are unused and should be removed. - `spring-cloud-gcp-pubsub-stream-polling-sample` is meant to be removed: #1287 (comment) - `spring-cloud-gcp-pubsub-stream-sample` replaced by [functional sample](https://github.com/GoogleCloudPlatform/spring-cloud-gcp/tree/main/spring-cloud-gcp-samples/spring-cloud-gcp-pubsub-stream-functional-sample)

…ve sample. (#1851) This pr cleans up setups in pom for `spring-cloud-gcp-data-firestore-sample` related to native support (configured with outdated `org.springframework.experimental:spring-native-configuration`). It reverts what's added for the sample in #508. The relevant native support module has stopped working for a while and was deleted in #1287. So it should be safe to also remove these setups in sample.

This sample was removed as part of #1287

JoeWang1127 linked an issue Oct 13, 2022 that may be closed by this pull request

Try to upgrade to Spring Boot 3.0 #1280

Closed

JoeWang1127 force-pushed the feature/boot3.0-migrator branch from 8cf7cb7 to b57dd4c Compare October 21, 2022 17:35

JoeWang1127 force-pushed the feature/boot3.0-migrator branch 2 times, most recently from 7429583 to ea807c7 Compare November 3, 2022 19:24

JoeWang1127 force-pushed the feature/boot3.0-migrator branch 2 times, most recently from 08ebdf6 to 69545ab Compare November 16, 2022 15:35

JoeWang1127 force-pushed the feature/boot3.0-migrator branch 6 times, most recently from 0cb8ffe to 80cbbd8 Compare December 3, 2022 02:27

JoeWang1127 force-pushed the feature/boot3.0-migrator branch 2 times, most recently from d5fbb9c to 4a2a4d7 Compare December 5, 2022 21:16

JoeWang1127 marked this pull request as ready for review December 5, 2022 21:29

JoeWang1127 requested review from zhumin8, mpeddada1, emmileaf and meltsufin December 6, 2022 23:31

JoeWang1127 marked this pull request as draft December 9, 2022 01:22

JoeWang1127 marked this pull request as ready for review December 9, 2022 02:01

JoeWang1127 linked an issue Dec 9, 2022 that may be closed by this pull request

Switch r2dbc-postgresql from groupId io.r2dbc to org.postgresql #1200

Closed

meltsufin reviewed Dec 9, 2022

View reviewed changes

JoeWang1127 added 4 commits December 11, 2022 20:59

applied boot-autoconfiguration-update

1ff21cd

extract sleuth dependency from spring-cloud-dependencies to io.microm…

4b3f6db

…eter dependency

add jakarta dependency

4adeaeb

extends crud repository for sorting repositories

55e9732

suztomo approved these changes Jan 19, 2023

View reviewed changes

JoeWang1127 merged commit 0caa9b6 into main Jan 19, 2023

JoeWang1127 deleted the feature/boot3.0-migrator branch January 19, 2023 19:47

emmileaf mentioned this pull request Jan 19, 2023

chore(codegen): add back release-please annotation #1481

Merged

ddixit14 changed the title ~~Upgrade to Spring Boot 3.0.0~~ feat!: Upgrade to Spring Boot 3.0.0 Jan 20, 2023

ddixit14 added the release-please:force-run label Jan 20, 2023

release-please bot removed the release-please:force-run label Jan 20, 2023

ddixit14 changed the title ~~feat!: Upgrade to Spring Boot 3.0.0~~ Upgrade to Spring Boot 3.0.0 Jan 20, 2023

ddixit14 added the release-please:force-run label Jan 20, 2023

release-please bot removed the release-please:force-run label Jan 20, 2023

ddixit14 added the release-please:force-run label Jan 23, 2023

release-please bot removed the release-please:force-run label Jan 23, 2023

release-please bot mentioned this pull request Jan 26, 2023

chore(main): release 4.0.0 #1495

Merged

pkutlunin mentioned this pull request Apr 23, 2023

Add Native Image Support in Spring Framework on Google Cloud #1565

Closed

zhumin8 mentioned this pull request May 8, 2023

chore(main): cleanup unused pom files. #1817

Merged

zhumin8 mentioned this pull request May 15, 2023

chore: cleanup and remove unsed pom entries #1851

Merged

zhumin8 mentioned this pull request Nov 27, 2023

chore: cleanup pom for removed sample. #2383

Merged

zhumin8 added a commit that referenced this pull request Nov 27, 2023

chore: cleanup pom for removed sample. (#2383)

5c922f2

This sample was removed as part of #1287

release-please bot mentioned this pull request Dec 18, 2023

chore(main): release 5.0.1 #2467

Merged

This was referenced Jul 29, 2024

chore: removed unused spring-cloud-gcp-native-support pom file. #3089

Merged

chore: removed unused pom file #3090

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to Spring Boot 3.0.0 #1287

Upgrade to Spring Boot 3.0.0 #1287

JoeWang1127 commented Oct 11, 2022 •

edited

Loading

JoeWang1127 commented Dec 5, 2022 •

edited

Loading

suztomo commented Dec 5, 2022

JoeWang1127 commented Dec 5, 2022

meltsufin left a comment

meltsufin Dec 9, 2022

JoeWang1127 Dec 15, 2022

nhmarujo Dec 18, 2022 •

edited

Loading

suztomo Dec 18, 2022 •

edited

Loading

JoeWang1127 Dec 18, 2022

suztomo Dec 18, 2022

meltsufin Dec 9, 2022

JoeWang1127 Dec 12, 2022

JoeWang1127 Dec 20, 2022

sonarqubecloud bot commented Jan 19, 2023

HabeebCycle commented Jan 19, 2023

ls-urs-keller commented Jan 24, 2023

Harmelodic commented Jan 31, 2023

HabeebCycle commented Jan 31, 2023

codependent commented Jan 31, 2023

JoeWang1127 commented Jan 31, 2023

Upgrade to Spring Boot 3.0.0 #1287

Upgrade to Spring Boot 3.0.0 #1287

Conversation

JoeWang1127 commented Oct 11, 2022 • edited Loading

Migration guide

Changes applied to all modules

Changes in each module

JoeWang1127 commented Dec 5, 2022 • edited Loading

suztomo commented Dec 5, 2022

JoeWang1127 commented Dec 5, 2022

meltsufin left a comment

Choose a reason for hiding this comment

meltsufin Dec 9, 2022

Choose a reason for hiding this comment

JoeWang1127 Dec 15, 2022

Choose a reason for hiding this comment

nhmarujo Dec 18, 2022 • edited Loading

Choose a reason for hiding this comment

suztomo Dec 18, 2022 • edited Loading

Choose a reason for hiding this comment

JoeWang1127 Dec 18, 2022

Choose a reason for hiding this comment

suztomo Dec 18, 2022

Choose a reason for hiding this comment

meltsufin Dec 9, 2022

Choose a reason for hiding this comment

JoeWang1127 Dec 12, 2022

Choose a reason for hiding this comment

JoeWang1127 Dec 20, 2022

Choose a reason for hiding this comment

sonarqubecloud bot commented Jan 19, 2023

HabeebCycle commented Jan 19, 2023

ls-urs-keller commented Jan 24, 2023

Harmelodic commented Jan 31, 2023

HabeebCycle commented Jan 31, 2023

codependent commented Jan 31, 2023

JoeWang1127 commented Jan 31, 2023

JoeWang1127 commented Oct 11, 2022 •

edited

Loading

JoeWang1127 commented Dec 5, 2022 •

edited

Loading

nhmarujo Dec 18, 2022 •

edited

Loading

suztomo Dec 18, 2022 •

edited

Loading