fix(codegen): modify generator scripts after separation of bazel rules #1351

emmileaf · 2022-11-21T14:57:16Z

This PR: edits generator scripts given the separation of the java_gapic_spring_library rule in googleapis/sdk-platform-java#1065 (please see its description for context of edits).

The script now makes local edits to:

googleapis/repository_rules.bzl (add switch)
google/cloud/<client_lib_name>/v1/BUILD.bazel (add rule name to load, and rule definition using similar arguments as java_gapic_library)

Note for review: the initial goal of these changes is to have something to unblock the code generation workflow, but there's currently a lot of perl mess so any suggestions on cleaner/more reliable file processing would be welcomed!

zhumin8

I agree on unblocking the generation workflow. So we could probably merge this in while working on improvements.
On making it more robust, I found this buildozer tool that looks neat. E.g. these two commands can achieve most of what we want building the java_gapic_spring_library rule.

# Add a new rule at the end of the file
buildozer 'new java_library foo' //pkg:__pkg__

# Copy an attribute from `protolib` to `py_protolib`.
buildozer 'copy testonly protolib' //pkg:py_protolib

Drawback is that it has dependencies on Go. But GithubAction does have https://github.com/actions/setup-go, so I guess it's not that bad.

emmileaf · 2022-11-21T16:23:47Z

On making it more robust, I found this buildozer tool that looks neat. E.g. these two commands can achieve most of what we want building the java_gapic_spring_library rule.

Oh buildozer does look like a better tool for handling BUILD.bazel file changes (esp. copying over attributes) - thanks for the suggestion @zhumin8 ! I’ll look into how to bring it in for our workflow, and will mark this PR as ready for review in the meanwhile.