Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DONOT MERGE] showing generated modules #1364

Closed
wants to merge 6 commits into from
Closed

[DONOT MERGE] showing generated modules #1364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a486045
WIP: add formatter step on top of pom edits
emmileaf Nov 22, 2022
7a37b36
WIP: clean up edits unrelated to change
emmileaf Nov 22, 2022
35eea14
Use fmt-maven-plugin 2.9.1 as latest version with Java 8 support
emmileaf Nov 23, 2022
a7872b1
Merge branch 'main' into codegen-include-formatter
zhumin8 Nov 28, 2022
bc69fe0
add generated modules.
zhumin8 Nov 29, 2022
9d22b02
removing versions that should inherent from parent pom.
zhumin8 Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion generated/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,6 @@
This is a list of starters we provide with dependencies and auto-configurations to work with corresponding Google Client Libraries.

| Client Library Starter | Maven Artifact Name |
|------------------------| --------------------|
|------------------------| --------------------|
|language|com.google.cloud:google-cloud-language-spring-starter|
|vision|com.google.cloud:google-cloud-vision-spring-starter|
34 changes: 34 additions & 0 deletions generated/language/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>

<parent>
<groupId>com.google.cloud</groupId>
<artifactId>generated-parent</artifactId>
<version>3.5.0-SNAPSHOT</version>
</parent>
<artifactId>google-cloud-language-spring-starter</artifactId>
<name>Spring Boot Starter - language</name>
<description>Spring Boot Starter with AutoConfiguration for language</description>


<dependencies>
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-language</artifactId>
<version>2.4.1</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect this version to be dependency managed by the parent that imports the libraries-bom.

</dependency>

<dependency>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter</artifactId>
</dependency>

<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>spring-cloud-gcp-core</artifactId>
</dependency>
</dependencies>

</project>
471 changes: 471 additions & 0 deletions ...main/java/com/google/cloud/language/v1/spring/LanguageServiceSpringAutoConfiguration.java
View file
Open in desktop

Large diffs are not rendered by default.

Loading