chore(codegen): add checkstyle suppressions for preview modules #1455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for lowerCamelCase handling of abbreviations
zhumin8
approved these changes
Jan 12, 2023
|
@zhumin8 That also makes sense, I was also debating between the two. Added in a new commit and updated the PR description to reflect this change. |
|
Kudos, SonarCloud Quality Gate passed!
|
meltsufin
reviewed
Jan 13, 2023
meltsufin
approved these changes
Jan 13, 2023
diegomarquezp
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR defines more specific checkstyle suppressions for generated modules in
spring-cloud-previewsadapted from #1449's commit 9036f7d. It looks likespring-cloud-gcpenforces stricter checkstyle rules (fail on warning) than what is used for the client libraries, and a number of abbreviation to lowerCamelCase edge cases are getting caught here.AbbreviationAsWordInNamesuppressions - for abbreviations in service names that appear in generated class names (e.g.IDSSpringProperties) , as well as abbreviations in rpc method names (affecting retry-related generated code) such as the getOSPolicyAssignment methodMethodNameandParameterNamesuppressions - for abbreviations in service names, from lines such as this iAMClient bean methodList of affected starter modules:
Related PR: googleapis/sdk-platform-java#1245