chore: update starter modules in spring-cloud-preview #1586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmileaf
reviewed
Feb 9, 2023
| @@ -232,6 +232,40 @@ public JobServiceSettings jobServiceSettings( | |||
| .cancelHyperparameterTuningJobSettings() | |||
| .setRetrySettings(cancelHyperparameterTuningJobRetrySettings); | |||
|
|
|||
| RetrySettings createNasJobRetrySettings = | |||
There was a problem hiding this comment.
This corresponds to changes from googleapis/google-cloud-java#9073
| @@ -92,9 +92,6 @@ protected TetherSpringAutoConfiguration( | |||
| @Bean | |||
| @ConditionalOnMissingBean(name = "defaultTetherTransportChannelProvider") | |||
| public TransportChannelProvider defaultTetherTransportChannelProvider() { | |||
| if (this.clientProperties.getUseRest()) { | |||
There was a problem hiding this comment.
This corresponds to useRestOption update in the generator: see googleapis/sdk-platform-java#1343 for details.
| @@ -1,222 +0,0 @@ | |||
| /* | |||
There was a problem hiding this comment.
This corresponds to the client library breaking change from googleapis/google-cloud-java#9036
|
Kudos, SonarCloud Quality Gate passed!
|
emmileaf
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created by Github action
--
This update PR was generated from the blocked dependabot branch in #1582, and also includes the libraries-bom update in an additional commit (because they are mutually blocking).
BEGIN_COMMIT_OVERRIDE
deps: bump libraries-bom from 26.5.0 to 26.7.0
fix: update starter modules in spring-cloud-preview
END_COMMIT_OVERRIDE