Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(codegen): allow base branch of github action to be different from main #1606

Merged
merged 2 commits into from
Feb 23, 2023

Conversation

emmileaf
Copy link
Contributor

This PR updates the existing github action to update generated modules, so that when the workflow is triggered from a branch other than main, the generated PR uses that branch as the base branch.

Use case: this allows for the workflow to be triggered from a branch created by dependabot (e.g. #1582), and generated PR will contain both the dependabot commits and any updates to spring-cloud-previews.

@sonarcloud
Copy link

sonarcloud bot commented Feb 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@diegomarquezp diegomarquezp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emmileaf emmileaf merged commit 986fd7f into main Feb 23, 2023
@emmileaf emmileaf deleted the codegen-actions-newbranch branch February 23, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants