This repository has been archived by the owner on Jan 14, 2023. It is now read-only.
Add PHP8 Compatibility #57
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frost-byte
force-pushed
the
php8
branch
3 times, most recently
from
f855707
to
ada7756
Compare
Fix compiler error for compile_ast Make the extension compatible with newer versions of php Convert final steps of docker build into a script Change `whitelist` to `allowed ` Make unit tests compatible with latest version of phpunit Add configuration for app engine project id Update CircleCI configuration Maintain backwards compat. for zval str dtor Make warning/notify tests backwards compatible Prevent seg fault when iterating logpoints in `ast_process` Install gcloud tools for Dockerfile using apt Remove memory leaks when creating debugger ast Update string assertions in phpunit tests Refactor Dockerfile to handle env vars needed for test build Add substitutions to cloudbuild Update php image versions used by cloudbuild Set cloud build timeout to 2100 seconds
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix compiler error for compile_ast
Make the extension compatible with newer versions of php
Convert final steps of docker build into a script
Change
whitelisttoallowedMake unit tests compatible with latest version of phpunit
Add configuration for app engine project id
Update CircleCI configuration
Maintain backwards compat. for zval str dtor
Make warning/notify tests backwards compatible
Prevent seg fault when iterating logpoints in
ast_processInstall gcloud tools for Dockerfile using apt
Remove memory leaks when creating debugger ast
Update string assertions in phpunit tests
Refactor Dockerfile to handle env vars needed for test build
Add substitutions to cloudbuild
Update php image versions used by cloudbuild
Cloudbuild
The updated cloudbuild.yaml has references to gcr images that are built using my PR for GCP/php-docker
Circle CI
The tests do not finish because they go over the 10 minute limit set by cloudbuild.
However, they do pass for the images generated by my PR for gae-php80, gae-php74 and gae-php73.
They also pass for php80-nts, it timed out during php80-zts
Whitelist > Allowed
I found documentation related to submitting code related to Google Projects that mentioned standards, including one that said the word 'whitelist' should not be used. So, all references to that have been changed to
AllowedDockerfile
I have added additional Build Arguments and Substitutions for cloudbuild to accommodate CircleCI.
This new Circle CI configuration requires a docker account/password to use the
google/cloud-sdk, though it could be reconfigured to use thecircleci/gcp-cliorb