Add DisplayName to Product struct #2037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[upstream:3907a64071e2aece0d26ef2e637e401a85ad1411] Signed-off-by: Modular Magician <magic-modules@google.com>
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
modular-magician
deleted the
downstream-pr-3907a64071e2aece0d26ef2e637e401a85ad1411
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
DisplayNameto Product structIn the current ruby code, if
display_nameis not provided, it will convert the name to the space separated sentence.For example, it converts
BlockchainNodeEnginetoBlockchain node enginehttps://registry.terraform.io/providers/hashicorp/google/latest/docs
After rewriting the function
GetDisplayNamewith Go, it works a little bit different.For example, it converts
BlockchainNodeEnginetoBlockchain Node Engineto match with other display names provided in the yaml files.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#10161