Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for "TLS_JA3_FINGERPRINT" and "USER_IP" options for enforceOnKey field in "compute_security_policy" and "compute_security_policy_rule" #2268

Conversation

modular-magician
Copy link
Collaborator

Adds support for "TLS_JA3_FINGERPRINT" and "USER_IP" options for "rateLimitOptions.enforceOnKey" field in compute_security_policy;
Also adds support for "rateLimitOptions" fields for compute_security_policy_rule;

Fixes: hashicorp/terraform-provider-google#17469

Release Note Template for Downstream PRs (will be copied)

compute: Added 'rateLimitOptions' field to 'google_compute_security_policy_rule' resource;
compute: Added 'TLS_JA3_FINGERPRINT' and 'USER_IP' options in field 'rateLimitOptions.enforceOnKey' to 'google_compute_security_policy' resource;

Derived from GoogleCloudPlatform/magic-modules#10596

…orceOnKey field in "compute_security_policy" and "compute_security_policy_rule" (#10596)

[upstream:0fec637d43ddae75c1b76cc96b9445ece63ecdcb]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician requested a review from a team as a code owner May 16, 2024 20:43
@modular-magician modular-magician requested review from melinath and removed request for a team May 16, 2024 20:43
@modular-magician modular-magician merged commit 825fb6d into GoogleCloudPlatform:main May 16, 2024
2 checks passed
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@modular-magician modular-magician deleted the downstream-pr-0fec637d43ddae75c1b76cc96b9445ece63ecdcb branch November 18, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TLS_JA3_FINGERPRINT is not supported in google_compute_security_policy resource
1 participant