Migrate Network Firewall Policy Rule (global and region) from DCL to MMv1 #2938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…MMv1 (#11368) Co-authored-by: Thomas Rodgers <thomasrodgers@google.com> [upstream:dfda8410197ea7c788909e5987067e25e938be9b] Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician
requested review from
ScottSuarez
and removed request for
a team
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
modular-magician
merged commit e4f3da9
into
GoogleCloudPlatform:main
1 of 2 checks passed
modular-magician
deleted the
downstream-pr-dfda8410197ea7c788909e5987067e25e938be9b
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello folks.
This PR is to move two Network Firewall Policy Rule resources (global and region) from DCL to MMv1.
google_compute_network_firewall_policy_rulegoogle_compute_region_network_firewall_policy_ruleAnd this PR includes:
Note: This PR doesn't include the actual deletion of the DCL resource.
Related to hashicorp/terraform-provider-google#18134
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#11368