Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check preconditions when reading. #561

Merged
merged 1 commit into from
Jul 20, 2021
Merged

Check preconditions when reading. #561

merged 1 commit into from
Jul 20, 2021

Commits on Jul 20, 2021

  1. Check preconditions when reading. 

    The official storage client does this incorrectly: it uses the XML api for reads but sends ifGenerationMatch
parameters (for the json api) rather than the required x-goog-if-generation-match headers. So instead check
this manually when the response comes back.

Also fix some related issues (cannot use the testgroup's conditions to read objects, similar thing for reading
the config).
    @fejta
    fejta committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    d384fbd View commit details
    Browse the repository at this point in the history