Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support monorepos with release-backed tokens #86

Merged
merged 2 commits into from
Nov 20, 2020
Merged

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Nov 19, 2020

Allows release-backed tokens to be generated with a monorepo option
if monorepo is enabled, release-backed tokens will look for matching
releases that contain the package-name suffix prefix, e.g., yargs-v1.0.0
sql-v1.0.2, rather than just v1.0.0, v1.0.2.

Allows release-backed tokens to be generated with a monorepo option
if monorepo is enabled, release-backed tokens will look for matching
releases that contain the package-name suffix, e.g., yargs-v1.0.0
sql-v1.0.2, rather than just v1.0.0, v1.0.2.
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 19, 2020
@codecov
Copy link

codecov bot commented Nov 19, 2020

Codecov Report

Merging #86 (6966cab) into master (e2686d1) will increase coverage by 1.73%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
+ Coverage   29.03%   30.77%   +1.73%     
==========================================
  Files          18       18              
  Lines        2228     2291      +63     
  Branches      105      121      +16     
==========================================
+ Hits          647      705      +58     
- Misses       1581     1586       +5     
Impacted Files Coverage Δ
src/server.ts 0.00% <0.00%> (ø)
src/lib/datastore.ts 30.88% <25.00%> (+0.02%) ⬆️
src/lib/packument.ts 47.85% <72.72%> (+1.40%) ⬆️
src/lib/write-package.ts 75.30% <90.90%> (+2.01%) ⬆️
src/lib/github.ts 67.77% <100.00%> (+5.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd05811...6966cab. Read the comment docs.

@bcoe bcoe requested a review from sofisl November 19, 2020 22:55
@bcoe
Copy link
Contributor Author

bcoe commented Nov 19, 2020

@sofisl this is to enable our work on googleapis.

Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ nits

src/lib/github.ts Outdated Show resolved Hide resolved
src/lib/github.ts Outdated Show resolved Hide resolved
test/lib/github.ts Show resolved Hide resolved
@bcoe bcoe merged commit ddb5421 into master Nov 20, 2020
@bcoe bcoe deleted the monorepo-support branch November 20, 2020 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants