-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add containerRunOptions #327
Merged
loosebazooka
merged 4 commits into
GoogleContainerTools:main
from
coopernetes:run-options
Mar 15, 2023
Merged
add containerRunOptions #327
loosebazooka
merged 4 commits into
GoogleContainerTools:main
from
coopernetes:run-options
Mar 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* largely picked up from GoogleContainerTools#82, add privileged, capabilities and host volume mounts. these are passed into HostConfig if set * added "user" field which corresponds -u/--user arg in docker wasn't tested for other drivers and more tests likely needed
* github.com/containerd/containerd - resolve CVE-2022-23471, CVE-2023-25153 & CVE-2023-25173 * golang.org/x/net - resolve CVE-2022-41717
loosebazooka
approved these changes
Mar 14, 2023
@coopernetes is this okay to merge? |
@loosebazooka yep, good to go! Thanks |
ddl-ebrown
added a commit
to ddl-ebrown/container-structure-test
that referenced
this pull request
Oct 24, 2023
- Support for --cap-add was added as part of GoogleContainerTools#327 - This rounds out the feature set to also include support for --cap-drop - Updates tests to drop "chown" capability and verify doing so works - closes GoogleContainerTools#389
ddl-ebrown
added a commit
to ddl-ebrown/container-structure-test
that referenced
this pull request
Feb 29, 2024
- Support for --cap-add was added as part of GoogleContainerTools#327 - This rounds out the feature set to also include support for --cap-drop - Updates tests to drop "chown" capability and verify doing so works - closes GoogleContainerTools#389
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
containerRunOptions
sectionCloses Support tests that require an interactive shell #283
Closes Passing secret from the outside using env variables #284
Closes Update vulnerable and old dependencies #309