feat: expose a Bazel rule #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
force-pushed
the
main
branch
5 times, most recently
from
9c1c7f3
to
bce2c73
Compare
thesayyn
approved these changes
Apr 28, 2023
alexeagle
force-pushed
the
main
branch
7 times, most recently
from
7a79331
to
5bfcfef
Compare
gregmagolan
approved these changes
Apr 29, 2023
loosebazooka
approved these changes
May 2, 2023
|
bleh, this macos build with podman is being weird. |
|
kk think this just needs a rebase once #343 goes in. |
Previously we documented that users should use the container_test rule from rules_docker: https://github.com/bazelbuild/rules_docker/blob/8c3a8110a0c519929a7e79c39ac345a0f8c74d04/contrib/test.bzl#L125 However, rules_docker is no longer maintained. rules_oci means to be a replacement, but doesn't want to add a rule for a binary that is published elsewhere. It's easier to understand if this repo publishes both the binary, and the bazel rule that wraps it, so that any changes can be made to them together.
|
Rebased, thanks for fixing the CI setup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we documented that users should use the container_test rule from rules_docker.
However, rules_docker is no longer maintained, and that rule was never documented.
rules_oci means to be a replacement, but doesn't want to add a
container_testrule for a binary that is published elsewhere.It's easier to understand if this repo publishes both the binary, and the bazel rule that wraps it, so that any changes can be made to them together.