Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Node.js support for Debian 12 #1402

Merged

Conversation

siketyan
Copy link
Contributor

This pull request adds Node.js (v18, v20) language support for Debian 12 (bookworm).
References #1398.

Signed-off-by: Natsuki Ikeguchi <me@s6n.jp>
@loosebazooka
Copy link
Member

I think @omBratteng is trying to handle this in #1317 ?

@siketyan
Copy link
Contributor Author

Yes, but it looks still in progress. I think we can merge #1317 first and then catch-up for Debian 12 support in this PR.

@omBratteng
Copy link
Contributor

You can just add Debian 12 support, and I'll rebase my PR to get those changes. I'm on a work trip now, so I don't have that much time to it right now.

Copy link
Member

@loosebazooka loosebazooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just need the debian 12 tests

@siketyan
Copy link
Contributor Author

@loosebazooka
I think we already have Debian 12 tests, as iterated in nodejs/BUILD.

❯ bazel test //nodejs:nodejs18_root_arm64_debian12_test
INFO: Build option --test_env has changed, discarding analysis cache.
INFO: Analyzed target //nodejs:nodejs18_root_arm64_debian12_test (166 packages loaded, 12586 targets configured).
INFO: Found 1 test target...
Target //nodejs:nodejs18_root_arm64_debian12_test up-to-date:
  bazel-bin/nodejs/nodejs18_root_arm64_debian12_test.sh
INFO: Elapsed time: 3.538s, Critical Path: 0.81s
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action
//nodejs:nodejs18_root_arm64_debian12_test                      (cached) PASSED in 5.2s

Executed 0 out of 1 test: 1 test passes.
There were tests whose specified size is too big. Use the --test_verbose_timeout_warnings command line option to see which ones these are.

@loosebazooka
Copy link
Member

you're right my bad, the testdata files are the same for both debian versions.

@loosebazooka loosebazooka merged commit af669b4 into GoogleContainerTools:main Sep 19, 2023
8 checks passed
@siketyan siketyan deleted the feat/nodejs-debian12 branch September 19, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants