feat: use cloudflare snapshot as the primary url #1531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The difference in speed can be seen here; Origin server first: https://github.com/GoogleContainerTools/distroless/actions/runs/8023783624/job/21920961029#step:5:1 |
loosebazooka
approved these changes
Feb 27, 2024
|
nice, this is awesome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon my experiments with this, after the first download from the cloudflare snapshot, the subsequent downloads were 30x faster. According to the headers sent by Cloudflare proxy, the TTL for cache is
31536000which is basically forever./ Risks
There are no risks to doing this as the fallback to origin server is still there, in case cloudflare mirror goes down (not likely unless they shut it down.). Also the deb packages are checked against the checksum so there's no risk of tampering.
This is going to take CI time down significantly.