Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring container creation timestamp in plugins #1609

Closed
TadCordle opened this issue Apr 8, 2019 · 2 comments · Fixed by #1888
Closed

Allow configuring container creation timestamp in plugins #1609

TadCordle opened this issue Apr 8, 2019 · 2 comments · Fixed by #1888

Comments

@TadCordle
Copy link
Contributor

instead of just whether or not to use current timestamp. We could change the useCurrentTimestamp parameter to take either a boolean, or an integer number of milliseconds since epoch, or rename the parameter to just timestamp and take a string to determine whether to use current timestamp or a specific timestamp.

@ST-DDT
Copy link

ST-DDT commented Apr 8, 2019

I would like to set the docker image timestamp to the time of the git commit that was used to build the underlying java classes. IIRC the docker image list has a created date, that shows the age of the image. Falsifying this image date results in a loss of useful information especially if "old images" should be garbage collected.

For plugins it might be useful to provide a timestamp + a format string to allow optimal flexibility when choosing the timestamp source.

@chanseokoh
Copy link
Member

chanseokoh commented Aug 19, 2019

1.5.0 released with the feature to configure the container creation time. See the jib.container.creationTime doc for Maven/Gradle.

For configuring file modification times, see #1608 (comment).

@ST-DDT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants