Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add container creation timestamp configuration #1888

Merged
merged 17 commits into from
Aug 9, 2019
Merged

Add container creation timestamp configuration #1888

merged 17 commits into from
Aug 9, 2019

Conversation

TadCordle
Copy link
Contributor

@TadCordle TadCordle commented Aug 2, 2019 •
edited
Loading

Fixes #1609. Adds container.creationTime config to maven and gradle. Accepted values are:

  • EPOCH - epoch + 1 second, same as files modification option
  • USE_CURRENT_TIMESTAMP - uses the current timestamp
  • an ISO 8601 date time

Also deprecates container.useCurrentTimestamp in favor of the USE_CURRENT_TIMESTAMP value.

chanseokoh
chanseokoh reviewed Aug 2, 2019
View reviewed changes
jib-gradle-plugin/src/main/java/com/google/cloud/tools/jib/gradle/TaskCommon.java Outdated Show resolved Hide resolved
jib-gradle-plugin/src/test/java/com/google/cloud/tools/jib/gradle/TaskCommonTest.java Outdated Show resolved Hide resolved
jib-maven-plugin/src/main/java/com/google/cloud/tools/jib/maven/JibPluginConfiguration.java Show resolved Hide resolved
jib-maven-plugin/src/test/java/com/google/cloud/tools/jib/maven/JibPluginConfigurationTest.java Outdated Show resolved Hide resolved
jib-maven-plugin/src/test/java/com/google/cloud/tools/jib/maven/JibPluginConfigurationTest.java Outdated Show resolved Hide resolved
...in/java/com/google/cloud/tools/jib/plugins/common/InvalidFilesModificationTimeException.java Show resolved Hide resolved
...on/src/main/java/com/google/cloud/tools/jib/plugins/common/PluginConfigurationProcessor.java Outdated Show resolved Hide resolved
...on/src/main/java/com/google/cloud/tools/jib/plugins/common/PluginConfigurationProcessor.java Outdated Show resolved Hide resolved
chanseokoh
chanseokoh reviewed Aug 5, 2019
View reviewed changes
Copy link
Member

@chanseokoh chanseokoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can update CHANGELOG in another PR, but I recently felt it is better to foster the practice to update CHANGELOG in the related PR.

jib-maven-plugin/src/main/java/com/google/cloud/tools/jib/maven/MojoCommon.java Outdated Show resolved Hide resolved
@TadCordle TadCordle marked this pull request as ready for review August 5, 2019 21:14
chanseokoh
chanseokoh reviewed Aug 6, 2019
View reviewed changes
Copy link
Member

@chanseokoh chanseokoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

jib-gradle-plugin/CHANGELOG.md Outdated Show resolved Hide resolved
jib-maven-plugin/CHANGELOG.md Outdated Show resolved Hide resolved
...src/integration-test/java/com/google/cloud/tools/jib/gradle/EmptyProjectIntegrationTest.java Outdated Show resolved Hide resolved
...rc/integration-test/java/com/google/cloud/tools/jib/gradle/SingleProjectIntegrationTest.java Outdated Show resolved Hide resolved
...rc/test/java/com/google/cloud/tools/jib/plugins/common/PluginConfigurationProcessorTest.java Outdated Show resolved Hide resolved
...ven-plugin/src/test/java/com/google/cloud/tools/jib/maven/BuildImageMojoIntegrationTest.java Outdated Show resolved Hide resolved
chanseokoh
chanseokoh reviewed Aug 6, 2019
View reviewed changes
Copy link
Member

@chanseokoh chanseokoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GoogleContainerTools/java-tools-build any objection to changing the default creation time from epoch to epoch + 1 sec?

jib-gradle-plugin/src/integration-test/resources/gradle/projects/simple/complex-build.gradle Show resolved Hide resolved
@TadCordle TadCordle requested a review from a team August 8, 2019 16:55
@TadCordle TadCordle merged commit 577e442 into master Aug 9, 2019
@TadCordle TadCordle deleted the i1609-container-creation-timestamp branch August 9, 2019 15:14
@chanseokoh chanseokoh mentioned this pull request Aug 9, 2019
Closed
4 tasks
chanseokoh added a commit that referenced this pull request Aug 16, 2019
@chanseokoh
Update README and FAQ for #1818, #1814, and #1888 (#1866)
a177e3e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chanseokoh chanseokoh chanseokoh approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow configuring container creation timestamp in plugins
3 participants
@TadCordle @chanseokoh @googlebot