Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enum for matching progress events to build steps #1449

Merged
merged 4 commits into from
Jan 29, 2019

Conversation

TadCordle
Copy link
Contributor

Part of #1054. This PR adds a BuildStepType enum, which is passed to progress events so that jib-core users may know which progress events correspond to which steps in the build.

I'm still not totally familiar with the progress system, so let me know if this seems like an ok direction to take.

Possible followups:

  • Add documentation for what each of the BuildStepTypes mean
  • Add an event for counting the number of layers involved in the push/pull steps, or modify/add progress events that make it possible to identify which layer a progress event was sent from

@TadCordle TadCordle requested review from a team and removed request for a team January 25, 2019 20:33
@TadCordle
Copy link
Contributor Author

TadCordle commented Jan 25, 2019

Going to add some tests, so no need to review thoroughly yet, but still open to high-level feedback.

@TadCordle TadCordle requested a review from a team January 28, 2019 18:48
@TadCordle TadCordle merged commit 83ab265 into master Jan 29, 2019
@TadCordle TadCordle deleted the i1054-progress-types branch January 29, 2019 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants