Deprecate <extraDirectory> config in Maven #1626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanseokoh
force-pushed
the
i1020-extra-directories-rename
branch
from
7e60c76 to
d02f668
Compare
|
Ready for review. Being a Maven list, the new syntax requires always having <extraDirectories>
<paths>
<path>/awesome/directory</path>
</paths>
</extraDirectories>People can continue to use the old syntax. They will see warnings. I should put up another PR for Gradle. |
jib-maven-plugin/src/main/java/com/google/cloud/tools/jib/maven/JibPluginConfiguration.java
Show resolved
Hide resolved
jib-maven-plugin/src/main/java/com/google/cloud/tools/jib/maven/JibPluginConfiguration.java
Show resolved
Hide resolved
jib-maven-plugin/src/main/java/com/google/cloud/tools/jib/maven/JibPluginConfiguration.java
Show resolved
Hide resolved
jib-maven-plugin/src/main/java/com/google/cloud/tools/jib/maven/skaffold/FilesMojo.java
Outdated
Show resolved
Hide resolved
jib-maven-plugin/src/main/java/com/google/cloud/tools/jib/maven/JibPluginConfiguration.java
Outdated
Show resolved
Hide resolved
loosebazooka
previously approved these changes
Apr 22, 2019
chanseokoh
commented
Apr 23, 2019
|
|
||
| String property = newProperty != null ? newProperty : deprecatedProperty; | ||
| if (property != null) { | ||
| return Collections.singletonList(Paths.get(property)); |
There was a problem hiding this comment.
Hmm... looks like I missed this part. The new property can be a list.
There was a problem hiding this comment.
So I missed handling this as list in the previous PR at this location: https://github.com/GoogleContainerTools/jib/pull/1602/files#diff-1aee6421b98ba15074ed3f0da4755bc5R175
Fixed with the latest commit.
|
I noticed that |
jib-maven-plugin/src/main/java/com/google/cloud/tools/jib/maven/JibPluginConfiguration.java
Show resolved
Hide resolved
loosebazooka
approved these changes
Apr 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1020.
Note
<extraDirectories>is a genuine list like<args>, so below will no longer be allowed.Also fixes #1625.