Add default timestamp to not-yet-existant parent dirs #1649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loosebazooka
commented
Apr 19, 2019
jib-core/src/test/java/com/google/cloud/tools/jib/image/ReproducibleLayerBuilderTest.java
Outdated
Show resolved
Hide resolved
|
probably going to have to do a cherry pick release off |
|
You mean 1.1.2, right? Sounds right. |
chanseokoh
approved these changes
Apr 19, 2019
jib-core/src/test/java/com/google/cloud/tools/jib/image/ReproducibleLayerBuilderTest.java
Show resolved
Hide resolved
loosebazooka
added a commit
that referenced
this pull request
Apr 19, 2019
* Add default timestamp to not-yet-existant parent dirs
loosebazooka
added a commit
that referenced
this pull request
Apr 19, 2019
- This only exists as tags v1.1.2-maven/gradle, not merged into master.
This was referenced Apr 19, 2019
loosebazooka
added a commit
that referenced
this pull request
Apr 19, 2019
* Add default timestamp to not-yet-existant parent dirs
loosebazooka
added a commit
that referenced
this pull request
Apr 19, 2019
loosebazooka
added a commit
that referenced
this pull request
Apr 19, 2019
loosebazooka
added a commit
that referenced
this pull request
Apr 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this defines a strong behavior for parents that don't exist in the layer yet.
fixes #1648
NOTE: This does not fix the out of order issue for defining directory permissions. That should be fixed in a followup (#1650)