Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a different marker so we don't clash with other jib json outputs #2192

Merged
merged 2 commits into from
Dec 18, 2019

Conversation

loosebazooka
Copy link
Member

This is to potentially protect us from the case where we run sync and files tasks together.

@loosebazooka loosebazooka requested a review from a team December 5, 2019 23:31
TadCordle
TadCordle previously approved these changes Dec 6, 2019
Copy link
Contributor

@TadCordle TadCordle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should use a more specific BEGIN JIB JSON message for the init and files tasks too (like BEGIN JIB INIT JSON and BEGIN JIB FILES JSON) Nevermind, I guess that'd break backwards compatibility.

@loosebazooka
Copy link
Member Author

Nevermind, I guess that'd break backwards compatibility.

Oh I didn't realize init had one too :. But, yeah it's probably worth coming up with a strategy for this eventually.

@briandealwis
Copy link
Member

Could we make this header a bit more easy to identify with a common prefix, and future-proofed by embedding a version?

BEGIN JIB JSON: SYNCMAP v1

So we can scan looking for BEGIN JIB JSON and if we're missing a colon then it indicates an older Jib.

We can now force a minimum Jib version, but that's quite disruptive. It might be worth looking at HTTP and how it handles version negotiation.

@loosebazooka
Copy link
Member Author

Updating this with new style, PTAL

@loosebazooka loosebazooka requested review from TadCordle and a team and removed request for TadCordle December 12, 2019 21:25
@loosebazooka loosebazooka merged commit 1439efa into master Dec 18, 2019
@loosebazooka loosebazooka deleted the use-new-json-start-marker-for-sync branch December 18, 2019 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants