Build plan adapter methods for JibContainerBuilder #2353
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds internal methods for conversion between
JibContainerBuilder
<-->ContainerBuildPlan
. I can't think of other ways to enable this conversion while not adding public methods toJibContainerBuilder
.As we currently build a
JibContainerBuilder
instance (which is the front-end public API) in our plugins code, the idea for the extension framework is basically like this:JibContainerBuilder
(current behavior).JibContainerBuilder
toContainerBuildPlan
and pass it to extensions.ContainerBuildPlan
.ContainerBuildPlan
back toJibContainerBuilder
.JibContainerBuilder
to build an image (current behavior)Another approach would be to revamp everything around
BuildContext
andContainerConfiguration
in jib-core. However, I think the amount of refactoring work to do so is prohibitively enormous, and this is not practical.