-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add and enable new plugin extension configuration in Gradle #2431
Conversation
…va-src-new-config
…n-extension-config
The plural on the base
or (and this matches most models I see like
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good, but have a few comments
Trying to find a way to make this work. I'll look into this later. UPDATE: done. The name of the new intermediate class |
(Gradle counterpart of #2420.)
Adds new extension configuration parameters for Gradle. Extensions can additionally get custom properties. The order of executing extensions will be the order defined in
pom.xml
.The following example configures two extensions.
That is, multiple(UPDATE: now new syntax with latest commits.)pluginExtensions
blocks are needed to configure multiple extensions. I've consulted the implementation of the Gradle plugin for Visual Studio Code IDE. I am not totally sure if this is the standard way, but I could not figure out a way to enable configuring extensions as a list likepluginExtensions = [ { ... }, { ... } ]
.Originally the name of the block was
extensions { ... }
. Although it did work, one of our test classes complained that their's ambiguity insetExtensions()
, so I went withpluginExtensions { ... }
. Seems like an acceptable renaming. Probably I'll have to rename the Maven configuration to be consistent.