Skip to content

Convert jib.*.auth.username and jib.*.auth.password to properties #2906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2020
Merged

Convert jib.*.auth.username and jib.*.auth.password to properties #2906

merged 1 commit into from
Dec 3, 2020

Conversation

dubinsky
Copy link
Contributor

@dubinsky dubinsky commented Dec 1, 2020

Fixes #2905

The following are now properties and not plain strings:

  • from.auth.username
  • from.auth.password
  • from.image
  • to.auth.username
  • to.auth.password

@dubinsky
Fixes #2905
9a6fd74 
The following are now properties and not plain strings:
- from.auth.username
- from.auth.password
- from.image
- to.auth.username
- to.auth.password
@google-cla

This comment has been minimized.

Sign in to view
@google-cla google-cla bot added the cla: no label Dec 1, 2020
@dubinsky
Copy link
Contributor Author

dubinsky commented Dec 1, 2020

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Dec 1, 2020
@dubinsky dubinsky mentioned this pull request Dec 1, 2020
Closed
@chanseokoh
Copy link
Member

Sorry for the delay. I'm trying to run some integration tests locally on this branch but having some issue.

@dubinsky
Copy link
Contributor Author

dubinsky commented Dec 3, 2020 •
edited
Loading

Sorry for the delay. I'm trying to run some integration tests locally on this branch but having some issue.

No worries; can I help?

chanseokoh
chanseokoh approved these changes Dec 3, 2020
View reviewed changes
Copy link
Member

@chanseokoh chanseokoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot for your contribution!

@chanseokoh chanseokoh merged commit eb5079a into GoogleContainerTools:master Dec 3, 2020
@chanseokoh chanseokoh mentioned this pull request Dec 3, 2020
Merged
@dubinsky
Copy link
Contributor Author

dubinsky commented Dec 4, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@chanseokoh chanseokoh chanseokoh approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert jib.to.auth.username and jib.to.auth.password to properties
3 participants
@dubinsky @chanseokoh @kokoro-team