Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate ErrorProne warnings #3410

Merged
merged 2 commits into from
Aug 17, 2021
Merged

Eliminate ErrorProne warnings #3410

merged 2 commits into from
Aug 17, 2021

Conversation

rainyShine
Copy link
Contributor

@rainyShine rainyShine commented Aug 12, 2021 •
edited by chanseokoh
Loading

For #3359.

@google-cla

This comment has been minimized.

Sign in to view
@google-cla google-cla bot added the cla: no label Aug 12, 2021
@rainyShine
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Aug 12, 2021
@chanseokoh
Copy link
Member

@rainyShine thanks for the PR. The builds are failing due to style violation. Try running ./gradlew googleJavaFormat.

@rainyShine
Copy link
Contributor Author

@chanseokoh Certainly.
I'm sorry to reread the guidelines.And I try that.

@rainyShine
Copy link
Contributor Author

@chanseokoh I've run below command ./gradlew googleJavaFormat and pushed.
Could you check again?

@sonarcloud
Copy link

sonarcloud bot commented Aug 16, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@chanseokoh
Copy link
Member

This is for #3359.

chanseokoh
chanseokoh approved these changes Aug 17, 2021
View reviewed changes
Copy link
Member

@chanseokoh chanseokoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rainyShine thanks a lot of fixing these! Merging now.

jib-cli/src/main/java/com/google/cloud/tools/jib/cli/buildfile/BaseImageSpec.java Show resolved Hide resolved
@chanseokoh chanseokoh merged commit d401e76 into GoogleContainerTools:master Aug 17, 2021
patrickpichler pushed a commit to patrickpichler/jib that referenced this pull request Aug 18, 2021
@rainyShine @v1tqm1n
Eliminate ErrorProne warnings (GoogleContainerTools#3410)
891f2ef 
* Eliminate ErrorProne warnings

* Eliminate ErrorProne warnings

Co-authored-by: torePos <b2bfired8@gmail.com>
@meltsufin meltsufin mentioned this pull request Aug 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suztomo suztomo suztomo left review comments

@chanseokoh chanseokoh chanseokoh approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rainyShine @chanseokoh @suztomo @kokoro-team @v1tqm1n